Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-3221] Pb when checksum is not available #3237

Conversation

xavierfacq
Copy link
Member

Fix issue #3221
When a checksum is not avaible we have to display an appropriate message.
This fix a problem when checksum is not available.

Checklist

  • npm test passes

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit a7d5dcb
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/673e0c1a7f3c3200086551bc
😎 Deploy Preview https://deploy-preview-3237--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.37%. Comparing base (454de9f) to head (64dae30).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/components/MarketplaceDownloadTable/index.tsx 66.66% 1 Missing ⚠️
src/components/TemurinArchiveTable/index.tsx 83.33% 1 Missing ⚠️
src/components/TemurinDownloadTable/index.tsx 66.66% 1 Missing ⚠️
src/components/TemurinNightlyTable/index.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   99.45%   99.37%   -0.09%     
==========================================
  Files          90       90              
  Lines        4765     4770       +5     
  Branches      627      631       +4     
==========================================
+ Hits         4739     4740       +1     
- Misses         26       30       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@xavierfacq xavierfacq requested a review from tellison November 20, 2024 16:23
@xavierfacq xavierfacq marked this pull request as ready for review November 20, 2024 16:23
@karianna karianna merged commit 2cf5438 into adoptium:main Nov 22, 2024
10 checks passed
@tellison
Copy link
Contributor

The alignment looks strange for me on Chrome ...

Screenshot 2024-11-22 at 11 46 00

@xavierfacq
Copy link
Member Author

Ok your are with macOS, and in this configuration, there is a little gap. I'll fix this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants